Use actual names for keys instead of inferring. #1891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1841 (comment)
Not sure if this is a bug in deno itself, but for now this doesn't work when building distributable binaries.
There is a distinction between the names of an exported value between
deno run
anddeno compile
when importing an object and using it as a key in a new objectIn
'https://deno.land/x/yargs_parser@v20.2.4-deno/deno.ts'
In
'https://deno.land/x/yargs/deno.ts'
This will create
{yargParser: Parser}
indeno compile
while work as intended withdeno run
where you get{Parser: Parser}
The codebase relies on
shim.Parser
and that will beundefined
when runningdeno compile
to build binaries as it would be calledshim.yargParser